I finished going through HQA and made another 9 screenshots. There is actually one game-stopper in "violence" after the part with the moon on the ceiling - the trigger_push doesn't seem to look upwards, hence the player just drops down like a rock. But hey - other than that, things look fine :D
(Also this box isn't in the corner for some strange reason.)
Moving through HQA really made me miss those HQA-specific sounds, so I decided to try and fix the button sounds before carrying on with my playthroughs.
Each part will have its own subfolder, i.e. buttons/hq2, buttons/hq3, doors/hq1, doors/hq2, etc.
At first I had some string concatenation problems (I'm not used to C++), but I worked it out with some stackoverflow help. It looked for the wav file in the correct folder when testing hq2_22 - but then this happened:
The floor started behaving very strangely. When I tried moving to the next level, it crashed. I probably screwed up some memory pointers or something.
It's always the pointers!!
I kept hacking away at it to the point where my Half-Life wouldn't even start anymore. I removed all std::string stuff and just tried it with regular chars, but no luck.
Further research led me to this entry, in which I found a neat function for joining two strings. I just used that, upvoted the answer and now it works. :D Each halfquake part has its own button sounds again!
I randomly played through some maps to test the new sounds and found out that in hq2_15 I was using ambient_generic entities with direct access to "buttons/button11.wav". :D I manually fixed all 10 of those and now I'm looking forward to more wrong sounds in the future (there won't be that many, I hope).
I'm happy I'm doing it this way, otherwise I'd have to add the paths to each individual wav file manually to every button in all three games. I think this way is much faster (and cleaner).
Taking a bit of a break from coding, I converted all 60 screenshots into issues on my github project for a better overview. It's hard for me to say where to draw the line with all the fixes. For example, I definitely want to fix the doors in the house of HQ1 by making them thinner and letting them open both ways. I also want to fix all the interior furniture, but I'm not sure if that's necessary. To me it is, because releasing it on Steam will invite lots of new people and they see it for the first time, but it can be alienating for players who've known it since it was released. I guess if it doesn't change the gameplay itself, it's fine.
We'll see once I tackle these problems.
To be continued... (<